Signature cache optimization #880
Closed
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! That looks like a decent optimization. I'm closing this PR in favor of #897. Please, take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a single endpoints.py file with all my endpoints in it, but it got to be unmaintainable. The problem is that wiring went from ~1 sec to ~2.5 on my MacBook Pro M2! No logic changed.
I dug in and it seems that the _fetch_reference_injections doesn't do any caching and this is an expensive operation. I'm a bit unclear why it would be scanning things multiple times though? I added some caching and this bumped by performance back to do pre-file split speeds.
I'll admit I used Claude to help me do this as I'm not super up to speed on the codebase nor the ins and outs of the inspect module, but the overall change makes sense to me.
Thoughts?